Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Op_Or_32(), Op_And_32() and tests #364

Merged
merged 4 commits into from
Jan 4, 2021
Merged

Added: Op_Or_32(), Op_And_32() and tests #364

merged 4 commits into from
Jan 4, 2021

Conversation

tuday2
Copy link
Collaborator

@tuday2 tuday2 commented Jan 2, 2021

-fixes farwest trivia crash

@tuday2
add SYSTEM_NAME textvar
a997d24 
-fixes farwest trivia crash
paladine
paladine reviewed Jan 2, 2021
View reviewed changes
Copy link
Collaborator

@paladine paladine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fix a bug? The new variable isn't exposed anywhere?

@tuday2
Copy link
Collaborator Author

tuday2 commented Jan 2, 2021 

2021-01-02 10:47:02.3892 Error MBBSEmu.HostProcess.ExportedModules.ExportedModuleBase.ProcessTextVariables Unknown Text Variable: SYSTEM_NAME
Unhandled exception. System.Exception: Unsupported Operation Size
   at MBBSEmu.CPU.CpuCore.Tick()
   at MBBSEmu.HostProcess.ExecutionUnits.ExecutionUnit.Execute(FarPtr entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.Module.MbbsModule.Execute(FarPtr entryPoint, UInt16 channelNumber, Boolean simulateCallFar, Boolean bypassSetState, Queue`1 initialStackValues, UInt16 initialStackPointer)
   at MBBSEmu.HostProcess.MbbsHost.WorkerThread()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.ThreadHelper.ThreadStart()

@tuday2 tuday2 changed the title add SYSTEM_NAME textvar Added: Op_Or_32(), Op_And_32() Jan 3, 2021
paladine
paladine requested changes Jan 3, 2021
View reviewed changes
Copy link
Collaborator

@paladine paladine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs tests for the opcodes

@tuday2 tuday2 changed the title Added: Op_Or_32(), Op_And_32() Added: Op_Or_32(), Op_And_32() and tests Jan 3, 2021
@tuday2 tuday2 requested a review from paladine January 3, 2021 17:40
@enusbaum enusbaum merged commit a17a003 into mbbsemu:master Jan 4, 2021
@tuday2 tuday2 deleted the add-system-name-tvar branch January 5, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enusbaum enusbaum enusbaum approved these changes

@paladine paladine Awaiting requested review from paladine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuday2 @paladine @enusbaum