Logsas input #377
Merged
Logsas input #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- LOGSAS uses `CHIINP` to manually add Input Characters to the Input Buffer - Because `BTUCHI` is returning `0`, we did't know when `ENTER` was being received - Because of this, we split the original character received vs. the processed character throught the pipeline - This allows us to take the appropriate action based on the character received while still maintaining the processed character
- Added Warning if printf/vsprintf formatter string is null - Fixed `morcnc`, still needs Unit Tests
- Added Compiler Optimizations for Inlining on Opcode Subroutines - Added missing Compiler Optimization Flags on several Opcodes
paladine
approved these changes
Jan 22, 2021
paladine
approved these changes
Jan 22, 2021
| @@ -258,6 +258,12 @@ private static bool InSpan(ReadOnlySpan<char> spanToSearch, ReadOnlySpan<byte> c | |||
| /// <returns></returns> | |||
| private protected ReadOnlySpan<byte> FormatPrintf(ReadOnlySpan<byte> stringToParse, ushort startingParameterOrdinal, bool isVsPrintf = false) | |||
| { | |||
| if (stringToParse.Length == 1 && stringToParse[0] == 0x0) | |||
There was a problem hiding this comment.
stringToParse.Length > 0 might be better, in case a larger string is sent in that begins with \0
| @@ -502,6 +502,9 @@ private void ProcessSTTROU(SessionBase session) | |||
| /// <param name="session"></param> | |||
| private void ExitModule(SessionBase session) | |||
| { | |||
| //Clear VDA | |||
| session.CurrentModule.Memory.FillArray($"VDA-{session.Channel}", 0x3FFF, 0x0); | |||
There was a problem hiding this comment.
nit: FillArray confuses me since the params are different than memset, memset wants value -> length whereas FillArray wants length -> value
There was a problem hiding this comment.
A ZeroMemory or ZeroArray overload would be nice
https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/aa366920(v=vs.85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
morcnc()implementation and added Unit TestsFillArraythat takes variable name for FarPtr