Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System variable replacement #392

Merged
merged 29 commits into from
Feb 7, 2021
Merged

Add System variable replacement #392

merged 29 commits into from
Feb 7, 2021

Conversation

tuday2
Copy link
Collaborator

@tuday2 tuday2 commented Jan 30, 2021

-Tested adding a variable called DATE with BBSDRAW.EXE (MajorBBS ANSI program)

@tuday2
Copy link
Collaborator Author

tuday2 commented Jan 31, 2021

-Still need to add justification detection and padding (first two characters and last 2 numbers), sample below
�R4TEXT_VAR_RJUS20�
�C9TEXT_VAR_CJ_25�
�N.TEXT_VAR_NOJUS�

@tuday2 tuday2 marked this pull request as ready for review February 5, 2021 01:08
@tuday2 tuday2 requested a review from enusbaum February 5, 2021 01:19
enusbaum
enusbaum requested changes Feb 6, 2021
View reviewed changes
MBBSEmu/Session/SessionBase.cs Outdated Show resolved Hide resolved
MBBSEmu/TextVariables/TextVariableService.cs Outdated Show resolved Hide resolved
@tuday2 tuday2 requested a review from enusbaum February 6, 2021 20:12
@enusbaum enusbaum merged commit 413724c into mbbsemu:master Feb 7, 2021
@tuday2 tuday2 deleted the system-variables branch February 7, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enusbaum enusbaum enusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuday2 @enusbaum