Fix for MajorMUD 1.11p Help File (MSG) #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MajorMUD 1.11p (WCCMMUD) uses a MSG file for parsing the help commands (using
sameto()
) and the help content. This file isn't exactly formatted consistently, specifically the MSG type definition is on its own line in several parts of the file:vs
Because of this, our MSG parsing code was identifying the
String
string as the following identifier, and since it containedspaces
and then alpha characters for the ACTUAL following identifier, it set the state toJUNK
for the actual identifier when it was encountered. This caused the offset of the MSG ordinals to be off and all kinds of bad memory overflows to happen.This SHOULD fix it, but it's not resilient as a MSG identifier followed by a
\r
before{
will be thrown away as junk. This probably needs some testing.