MajorMUD 1.11p for DOS Fixes (WCCMMUD) #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the refactor to handle
STATUSas a FIFO queue, inProcessIncomingCharacter(), when0xDwas detected, it wasn't enqueuing a status of3unless the queue was empty. Because MajorMUD uses polling, theSTATUSqueue contained192, meaning the input ready status of3wasn't being added.I changed the logic to always enqueue status of
3on0xDinput, after it does the BTUCHI input check. This is the correct action.Fixing this re-enables input on MajorMUD
I also added a couple more friendly error messages/help when the MajorBBS/Worldgroup module isn't configured or installed properly.