Add -PWRESET Command Line Argument #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `-PWRESET` Command Line Argument to reset Sysop Password - Moved Password Prompt to common method (used by `-DBRESET` as well) - Moved GUI to start after pre-launch items (Password reset, etc.)
paladine
approved these changes
Nov 22, 2023
MBBSEmu/Program.cs
Outdated
| /// <exception cref="Exception"></exception> | ||
| private string PasswordPrompt(string username) | ||
| { | ||
| var bPasswordMatch = false; |
There was a problem hiding this comment.
friends don't let friends use Hungarian Notation
|
|
||
| var acct = _serviceResolver.GetService<IAccountRepository>(); | ||
| var sysopAccount = acct.GetAccountByUsername("sysop"); | ||
| acct.UpdateAccountById(sysopAccount.accountId, sysopAccount.userName, _newSysopPassword, sysopAccount.email); |
There was a problem hiding this comment.
can we clear the _newSysopPassword reference for security purposes here?
- Just make Password Prompt and infinite loop until they match - Set `_doResetPassword` to false when the password is reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-PWRESETCommand Line Argument to reset Sysop Password-DBRESETas well)Fixes #542