Logging & Exception Fixes #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `CATASTRO` messages were being written to the console, not the Logger
This routine would fail if a user wasn't "IN" a module, but "IN" a module. An example is running a login routine after login. Because the user wasn't _IN_ the module, this loop would throw an exception.
paladine
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small fixes around exception handling.
CATASTROerrors were being written to console, not the logger. This means they weren't included in the GUI logs and were lost.This fix allows the module to still be disabled, and since the users are in non-interactive routines, no need to "Gracefully" exit them, they'll exit anyway.