Bit Rotation & FPU Evaluation Fixes #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We were only handling `NaN` as invalid, but `Infinity` is also invalid so we need to set flags properly in case of both. - Updated Unit Tests
- Add Overflow Flag logic for RCR - Add Additional Logging for FPU stack
- Unhandled exception would be thrown while generating a Crash Report if a module crashed without executing code (Loading, etc.)
- `FILD` was converting memory integer values to unsigned values before casting to double - Added helper method to maintain signed value of memory/register values - `FILD` updated to take signed value from memory/registers - Updated Unit Tests for `FILD` to use signed types
paladine
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
FILDto be signed (and updated Tests)Add Error Handling in Exception Report for situations where a module throws an exception while not executing an instruction (loading, etc.)
Enhanced Debugging output to make CPU debugging easier
Add Overflow Logic to
ROR, andRCLSet FPU Flags properly for
FCOM,FCOMP,FCOMPPhandlingdouble.(Positive/Negative)Infinityas an invalid value