Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STM32F103xD, STM32F103xG series and fix STM32F103xE startup file #151

Merged
merged 3 commits into from
Mar 11, 2023

Conversation

jancotipsarevic
Copy link

@jancotipsarevic jancotipsarevic commented Mar 10, 2023

Summary of changes

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@multiplemonomials
Copy link
Collaborator

Hi! Thank you for the contribution.

Any way you could provide some more detail on the motivation for this change? What boards are these chips used in? Or are they for custom boards only?

@JohnK1987
Copy link
Member

I believe it is in context of this question #124

These MCUs were added to ARM MbedOS in January, exactly 2 days after last Upstream merge, but many more changes were done and Mbed OS6.17 was also released.

@jancotipsarevic
Copy link
Author

Hi! Thank you for the contribution.

Any way you could provide some more detail on the motivation for this change? What boards are these chips used in? Or are they for custom boards only?

I need it for custom boards. My first intention is to port one existing application (STM32F103xD) using Mbed Studio to Mbed-CE+CLion, and I plan to start a new application using STM32F103VG.

@jancotipsarevic
Copy link
Author

jancotipsarevic commented Mar 11, 2023

I believe it is in context of this question #124

These MCUs were added to ARM MbedOS in January, exactly 2 days after last Upstream merge, but many more changes were done and Mbed OS6.17 was also released.

It would be great to update to 6.17 , this of course will solve my issue, but I could imagine it is a huge work, I will be more than happy if this PR is accepted to start working seriously with Mbed-CE asap.

@multiplemonomials
Copy link
Collaborator

Oh so this code is copied straight from Mbed?

@jancotipsarevic
Copy link
Author

Oh so this code is copied straight from Mbed?

Yes, it is.

@multiplemonomials
Copy link
Collaborator

In that case, this can be greenlighted! I just thought that you wrote all this yourself so I wanted some more background info.

@jancotipsarevic
Copy link
Author

In that case, this can be greenlighted! I just thought that you wrote all this yourself so I wanted some more background info.

Sorry, next time I´ll be more specific. Thank you very much.

@multiplemonomials multiplemonomials merged commit ed4c4f4 into mbed-ce:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants