Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutate Array(foo) -> [foo] #1043

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Mutate Array(foo) -> [foo] #1043

merged 1 commit into from
Aug 26, 2020

Conversation

dgollahon
Copy link
Collaborator

meta/send.rb Outdated Show resolved Hide resolved
@mbj
Copy link
Owner

mbj commented Aug 26, 2020

@dgollahon I agree with mutation and code. I've to go AFK, and will merge on green after rebase. Maybe you beat me to the rebase.

@mbj
Copy link
Owner

mbj commented Aug 26, 2020

I agree that #172 was closed unjustified.

- See #172. While #172 was closed outright, I think the rationale behind closing it is incorrect since the generic mutation there does not cover the proposed case. The benefit of using `[foo]` over `Array(foo)` if you have only scalar values is that you are using the simpler/narrower tool.
@mbj mbj merged commit 1470ebe into master Aug 26, 2020
@mbj mbj deleted the add-array-mutation branch August 26, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants