Add a === b -> a.is_a?(b) mutation
#1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
force-pushed
the
add-is_a-mutation
branch
from
94322f9
to
fbd95c0
Compare
dgollahon
commented
Jan 2, 2021
| @@ -17,6 +17,7 @@ class Send < self | |||
| :< => %i[== eql? equal?], | |||
| :<= => %i[< == eql? equal?], | |||
| :== => %i[eql? equal?], | |||
| :=== => %i[is_a?], | |||
There was a problem hiding this comment.
@mbj I wonder if this should also have a mutation to #eql??
dgollahon
force-pushed
the
add-is_a-mutation
branch
from
fbd95c0
to
850501a
Compare
mbj
previously approved these changes
Jan 2, 2021
- Closes #689 * NOTE: I have gone with `is_a?` over `kind_of?` because [this is more commonly used](https://github.com/rubocop-hq/ruby-style-guide#is-a-vs-kind-of)
dgollahon
force-pushed
the
add-is_a-mutation
branch
from
850501a
to
8624245
Compare
mbj
approved these changes
Jan 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foo === bar→bar.kind_of?(foo)#689is_a?overkind_of?because this is more commonly used