Add sorbet method matching #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
add/sorbet-method-matching
branch
3 times, most recently
from
e78f960
to
11ab768
Compare
mbj
force-pushed
the
add/sorbet-method-matching
branch
3 times, most recently
from
ef97a48
to
dd21ff9
Compare
mbj
force-pushed
the
add/sorbet-method-matching
branch
3 times, most recently
from
302597f
to
db85e90
Compare
* Signatures with sorbet-runtime enabled wrap the method into a Proc. * This proc hides the original source location, which would, by default not enable mutant to find the method source. * Using sorbet private API to uncover the original method prevents this issue.
mbj
force-pushed
the
add/sorbet-method-matching
branch
from
db85e90
to
2e366a7
Compare
| a clean dependency, that unless told to: Will not perform core extensions. | ||
|
|
||
| As mutant is a development dependency it should not be an issue for a project | ||
| that mutant itself will soonm use sorbet type checks to accelerate its |
|
This is awesome, thanks @mbj ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not enable mutant to find the method source.
issue.