Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with activerecord 4.1.0.beta1 #435

Closed
eagletmt opened this issue Dec 18, 2013 · 2 comments · Fixed by #446
Closed

Incompatibility with activerecord 4.1.0.beta1 #435

eagletmt opened this issue Dec 18, 2013 · 2 comments · Fixed by #446

Comments

@eagletmt
Copy link
Contributor

I found 2 incompatibilities with activerecord 4.1.0.beta1.

First, quote_value requires the second argument.
rails/rails@31a43eb
I think it can be fixed easily by passing nil explicitly.

Second, the SQL statement generated from count changes.
rails/rails@da9b5d4
In acts-as-taggable-on, tags.count or tags.empty? performs an invalid query.
Using tags.count(:all) may solve this issue.

@bf4
Copy link
Collaborator

bf4 commented Dec 19, 2013

Thanks for the links. Would you want to make a pull request?

@eagletmt
Copy link
Contributor Author

@bf4 I've made a pull request. Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants