ActiveRecord 4.1 compatibility #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it seems to lose AR 3 compatibility... I'll investigate. |
In ActiveRecord 3, Model.all returns an Array.
| @@ -125,7 +125,7 @@ | |||
| end | |||
|
|
|||
| it "should have tag_counts_on" do | |||
| TaggableModel.tag_counts_on(:tags).should be_empty | |||
| TaggableModel.tag_counts_on(:tags).count(:all).should be_zero | |||
There was a problem hiding this comment.
hmm, so this test doesn't cover the tags.is_a?(Array) scenario...
|
I tried another way to fix about |
| @@ -2,7 +2,11 @@ module ActsAsTaggableOn | |||
| module TagsHelper | |||
| # See the README for an example using tag_cloud. | |||
| def tag_cloud(tags, classes) | |||
| return [] if tags.empty? | |||
| if tags.is_a?(Array) | |||
There was a problem hiding this comment.
def tag_cloud(tags, classes)
return [] if no_tags?(tags)
....
end
def no_tags?(tags)
if tags.is_a?(ActiveRecord::Relation)
tags.count(:all).zero?
else
tags.blank?
end
end
|
See #445 (you'll probably have to rebase once it's merged) |
|
Oh, you know you can force push to the same remote branch and it will update the PR? |
|
Closed per #446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #435.