PostgreSQL Errors in 3.2.3 vs. 3.1.1

[vanboom]

Hi,
I am not able to upgrade my Rails 4.0.2 app to acts-as-taggable-on 3.2.3.

@clients = Client.where(:active=>true).tagged_with(@tag.name,:order=>'lname asc')
@not_clients = Client.where(:active=>true).tagged_with(@tag.name,:exclude=>true,:order=>'lname asc')

Statements like these are causing PostgreSQL errors stating that the field used in ORDER or GROUP BY must appear in the SELECT list.

This is not happening for 3.1.1. Thanks for an amazing gem - please advise.

[Skulli]

Having the same problem here on rails 3.2.18.
The statement tagged_with does a GROUP BY now, which did not happen in the previous versions.

[seuros]

Ok, i will try to fix this one too, today.

[seuros]

@Skulli , @vanboom , can you provide a test case ?
I can't reproduce this error.

[Skulli]

Document.tagged_with("Test", :any => true, :wild => true)

This generates a GROUP BY in the statement, which did not happen in the previous version.
The statement alone gives a correct result but i am merging it with another scope.

With the above call as scope doc_scope i have a query like

AnotherModel.joins(:document).merge(doc_scope).except(:select)

The except is important, otherwise it would call

SELECT documents.*

instead of

SELECT another_model.*

[seuros]

Ok, i will give it a try again. Thank you for your reply

[seuros]

@Skulli , @vanboom can you try 3c9b170 ?

I can't remove the group by since it resolve an issue with duplicate tags.

In 3.1.1, tables with json,hstore columns were throwing an error when we used DISTINCT.

I tried to fix it without breaking any tests. The one side effect with group by is that .count return a hash instead of integer.

Let me know if that work for you so i can merge this to master and release v 3.2.4

[Skulli]

Stupid question maybe, but how do i check that commit out?

gem 'acts-as-taggable-on', :git => "https://github.com/mbleigh/acts-as-taggable-on.git", :ref => "3c9b170667477fb854f95a1d89867e3fd64622ef"

did not work for me, commit/ref isnt known.

[seuros]

@Skulli that correct, i just found a bug in the new code. I will update you once i push the changes.

[seuros]

@Skulli :
gem 'acts-as-taggable-on', :git => "https://github.com/seuros/acts-as-taggable-on.git", branch: 'taglistparser'
You will be able to use the rubygem version or master branch once this ticket is closed by the merge.

you will have to use 'Document.tagged_with("Test", any: 'distinct', wild: true)' .

[Skulli]

branch isnt pushed to origin yet, cant fetch it

[seuros]

Note that it my fork and not this one.
https://github.com/seuros/acts-as-taggable-on/tree/taglistparser

[Skulli]

Sorry my bad.

Seems to work now, not getting errors anymore and results are correct.

[seuros]

You can use master now.

[seuros]

And now from rubygems.