rails 4.2 text_field issue

[ghost]

Hi. I'm using ruby 2.1.5 and recently upgraded to rails 4.2. I noticed ActionView::Helpers::Tags::TextField no longer calls html_safe on its value, which means that for a post with tag_list ['ruby', 'rails'], the following erb block
<%= f.text_field :tag_list %>
produces
<input type="text" value="ruby rails" name="post[tag_list]" id="post_tag_list">
rather than
<input type="text" value="ruby, rails" name="post[tag_list]" id="post_tag_list">

It's easily fixed by
<%= f.text_field :tag_list, value: @post.tag_list.to_s %>
but I was wondering if there's a way to go about this issue without having to specify the value option each time?

[seuros]

Yes, this is by design for security reasons.
But we could add an option to html safe the tags by default.

[DaniG2k]

It would be nice, yes. Right now I am also forced to do:

<%= f.label tag.to_s.titleize %>
<% tag_sym = "#{tag.to_s.singularize}_list".to_sym %>
<% tag_list = "#{tag.to_s.singularize}_list" %>
<%= f.text_field tag_sym, value: @article.send(tag_list).to_s, :placeholder => "Comma-separated list of #{tag.to_s}", class: 'form-control' %>

Note: I asked this on StackOverflow as well 😦

[bf4]

The best option might be to make a custom input for the form builder

[ghost]

Seems like the easiest way is to make a custom tag_list_field where the input type defaults to text or can be specified. Thanks for the help!

[lenart]

Not being able to use Rails' form helpers "out of the box" feels a bit weird to me as well.

Could @seuros or @bf4 explain why you decided to take this approach? You mentioned security but I'd like to understand this better.

[stiff]

Maybe just add glued_tags and glued_tags= to use in forms?

[openscript]

What kind of security feature are you talking about?

[tirdadc]

Why was this closed when no explanation for this change was provided?

[ScotterC]

This should be noted in a changelog somewhere because on upgrade to 4.2 I had some production projects lose tag data because when the resources were saved again the commas were lost and it created new tags.

[AlexVPopov]

Created a wiki-page, addressing this issue.

[carlflor]

For simple_form it's like this:

<%= f.input :tag_list, input_html: {value: @something.tag_list.to_s} %>

[korny]

This was our solution:

module ActionView::Helpers::TagHelper
  private
  def tag_option_with_tag_list_support(key, value, escape)
    if value.is_a?(ActsAsTaggableOn::TagList)
      value = escape ? ERB::Util.unwrapped_html_escape(value) : value.to_s
    end

    tag_option_without_tag_list_support key, value, escape
  end
  alias_method_chain :tag_option, :tag_list_support
end