Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check to see if we can connect to the db before accessing it. Fixes #396. #403

Merged
merged 1 commit into from
Dec 10, 2013

Conversation

shekibobo
Copy link
Contributor

Fix heroku precompile assets breaking with Rails 4. Fixes #396.

This fails specs for unrelated reasons that have been addressed in #404. I have been able to deploy to Heroku with an app running Rails 4 using this fork. It should be good to merge.

@davidstosik
Copy link

👍
This helped, thanks!

@bf4
Copy link
Collaborator

bf4 commented Dec 10, 2013

Can you rebase against master and force push?

@shekibobo
Copy link
Contributor Author

#422 might be a better implementation of a fix for #396.

@bf4
Copy link
Collaborator

bf4 commented Dec 10, 2013

Yours is more consistent with current behavior.. would need to think about #422 a bit

bf4 added a commit that referenced this pull request Dec 10, 2013
Check to see if we can connect to the db before accessing it. Fixes #396.
@bf4 bf4 merged commit 4435795 into mbleigh:master Dec 10, 2013
@aaronchi
Copy link

This broke a rails4 app I'm working on. The methods don't get added. This doesn't seem like the correct way to do this.

@bf4
Copy link
Collaborator

bf4 commented Dec 11, 2013

@aaronchi Would you mind creating an issue and giving an example?

@aaronchi
Copy link

@bf4 After this patch, I get ActionView::Template::Error: undefined methodcaching_tag_list_on?' for #Class:0x007f1c477b4570` when trying to render tag_list to a form. If I remove the base.connected? part, it works.

It seems that if these methods can't be written on initialization, it breaks the functionality of the gem. Seems like #422 might be a better alternative.

@bf4
Copy link
Collaborator

bf4 commented Dec 11, 2013

Thanks.. Would you mind creating an issue with the gem version, rails version, ruby version, full error message, and a stack trace?

bf4 added a commit to bf4/acts-as-taggable-on that referenced this pull request Dec 19, 2013
bf4 added a commit that referenced this pull request Dec 22, 2013
[#432][#403][#433][#422] Fix checking for column cache until db connects
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Check to see if we can connect to the db before accessing it. Fixes mbleigh#396.
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Rails 4, causes rake assets:precompile incorrectly to attempt to initialize DB connection
5 participants