-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check to see if we can connect to the db before accessing it. Fixes #396. #403
Conversation
👍 |
Can you rebase against master and force push? |
Yours is more consistent with current behavior.. would need to think about #422 a bit |
Check to see if we can connect to the db before accessing it. Fixes #396.
This broke a rails4 app I'm working on. The methods don't get added. This doesn't seem like the correct way to do this. |
@aaronchi Would you mind creating an issue and giving an example? |
@bf4 After this patch, I get It seems that if these methods can't be written on initialization, it breaks the functionality of the gem. Seems like #422 might be a better alternative. |
Thanks.. Would you mind creating an issue with the gem version, rails version, ruby version, full error message, and a stack trace? |
… column cache until db connects Specifically see, mbleigh#432 (comment)
Check to see if we can connect to the db before accessing it. Fixes mbleigh#396.
… column cache until db connects Specifically see, mbleigh#432 (comment)
[mbleigh#432][mbleigh#403][mbleigh#433][mbleigh#422] Fix checking for column cache until db connects
Fix heroku precompile assets breaking with Rails 4. Fixes #396.
This fails specs for unrelated reasons that have been addressed in #404. I have been able to deploy to Heroku with an app running Rails 4 using this fork. It should be good to merge.