thread safe configuration #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add this change to the CHANGELOG and force push ? |
|
@seuros, thanks! I have updated changelog. It's a pity I can't add test for that which needs JRuby. |
|
'Replaced class variables in configuration' is ambiguous , i think it should be "Thread safe support" |
|
cc @bf4 , any comment on this PR ? |
|
@billychan Can you do the rewording so i can merge this PR ? @bf4 , If you don't see anything wrong here, i will merge it. |
|
@seuros , sure. Done. Thanks! |
|
@seuros Sorry I've been AWOL :( |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Thread safe support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace class variables to instance variables in configuration for thread safety.