Rename migration to avoid conflicts #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AddMissingIndexes migration conflicts with migrations in other gem(s), eg spree 3.1. The name has been made more specific to avoid such conflicts.
|
@seuros Hi, is it possible to make a new release 4.0.1 with this PR merged? That'll allow me to use 4.0.1 instead of pointing to master branch |
|
@arpitchauhan because file name is changed, |
|
@krzysiek1507 indeed, I will make a new PR with that change. |
|
@arpitchauhan could you add it for all migrations with changed names? |
|
@krzysiek1507 @seuros I created #779 What other migrations have changed names? |
|
@arpitchauhan sorry, I've checked and this is only one. I thought there is more. |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Rename migration to avoid conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AddMissingIndexes migration conflicts with migrations in other
gem(s), eg spree 3.1. The name has been made more specific to avoid
such conflicts.
Fixes issue #773