use ActiveRecord::Migration version 5.0 or 5.1 instead of 4.2 #930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
ActiveRecord::Migration[4.2]
as default migration version, sooner we migrate to 5 betterbigint
, useActiveRecord::Migration[5.1]
can also help us adapt this change, make it more consistentNotable point
t.references
will add index automatically, to keep migration result consistent, I addindex: false
fortag
,taggable
,tagger
to prevent extraindex_taggings_on_taggable_type_and_taggable_id
andindex_taggings_on_tagger_type_and_tagger_id
indexbigint
(if your database supportsbigint
)