Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict_case_match doesn't work as expected #965

Closed
endorfin opened this issue Sep 5, 2019 · 3 comments
Closed

strict_case_match doesn't work as expected #965

endorfin opened this issue Sep 5, 2019 · 3 comments

Comments

@endorfin
Copy link
Contributor

endorfin commented Sep 5, 2019

As I noticed today, the option ActsAsTaggableOn.strict_case_match = true only works for creating new tags, but not with the tagged_with scope.

After a little research I found out that the third parameter case_sensitive for matches and matches_any in query_base.rb (tag_match_type, tags_match_type) isn't set.

So there is always a search with ILIKE.
endorfin added a commit to endorfin/acts-as-taggable-on that referenced this issue Sep 5, 2019
@endorfin
case sensitivity fix for tagged_with mbleigh#965
7dbff9f 
arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL
@endorfin
Copy link
Contributor Author

endorfin commented Sep 6, 2019

pull request #966

Andythurlow pushed a commit to Andythurlow/acts-as-taggable-on that referenced this issue Mar 5, 2020
@endorfin @Andythurlow
case sensitivity fix for tagged_with mbleigh#965
fb84c4d 
arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL
@Andythurlow Andythurlow mentioned this issue Mar 5, 2020
Merged
seuros pushed a commit that referenced this issue May 7, 2020
@Andythurlow @endorfin
case sensitivity fix for tagged_with #965 (#990)
47da503 
arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL

Co-authored-by: René Kersten <rene.kersten@gmail.com>
@nbulaj
Copy link
Contributor

nbulaj commented May 7, 2020

This one could be closed now I think as #966 merged

@endorfin
Copy link
Contributor Author

endorfin commented May 7, 2020

Thanks!

@endorfin endorfin closed this as completed May 7, 2020
This was referenced Mar 12, 2021
Merged
Closed
rolandoalvarado pushed a commit to rolandoalvarado/acts-as-taggable-on that referenced this issue Nov 11, 2021
@Andythurlow @endorfin @rolandoalvarado
case sensitivity fix for tagged_with mbleigh#965 (mbleigh#990)
f4c1b25 
arel matches and matches_any has a third parameter for case sensitivity, that was not set and always false. So ActsAsTaggableOn.strict_case_match didn't work with PostgreSQL

Co-authored-by: René Kersten <rene.kersten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@endorfin @nbulaj