-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump acts-as-taggable-on from 4.0.0 to 7.0.0 #7084
Bump acts-as-taggable-on from 4.0.0 to 7.0.0 #7084
Conversation
I think this may help with a few broekn specs in rails 5.2:
|
there are some broken specs, maybe we try v6.5 instead? |
@dependabot-bot rebase |
Bumps [acts-as-taggable-on](https://github.com/mbleigh/acts-as-taggable-on) from 4.0.0 to 7.0.0. - [Release notes](https://github.com/mbleigh/acts-as-taggable-on/releases) - [Changelog](https://github.com/mbleigh/acts-as-taggable-on/blob/master/CHANGELOG.md) - [Commits](mbleigh/acts-as-taggable-on@v4.0.0...v7.0.0) Signed-off-by: dependabot[bot] <support@github.com>
0b095f2
to
1fcc77d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a green Github build (albeit from a few days ago), I think this looks good. Probably should have a general release test before merging though?
I think we can be pretty confident with a green build here. We use tagging in 6+ core classes, and that behavior is covered in tests. |
ok, we need to merge or rebase rails-5-2 branch to get this in there. |
Bumps acts-as-taggable-on from 4.0.0 to 7.0.0.
Release notes
Sourced from acts-as-taggable-on's releases.
Changelog
Sourced from acts-as-taggable-on's changelog.
... (truncated)
Commits
4c49575
release 7.0.006bf141
Merge pull request #1013 from kvokka/add-rails-6-1-support37bfebc
Add Rails 6.1 support47da503
case sensitivity fix for tagged_with #965 (#990)6f8d018
Update README.md (#998) [ci skip]89a4d7f
Add support for Ruby 2.7 and it's kwargs (#999)6055f96
Update CHANGELOG.md (#980)6b38c65
Merge pull request #940 from iiwo/refactor/simplify_relation_optionsf8a3dc2
Merge pull request #941 from iiwo/refactor/remove_unneeded_spec_case950c010
Release 6.5 (#968)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)