Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump acts-as-taggable-on from 4.0.0 to 7.0.0 #7084

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2021

Bumps acts-as-taggable-on from 4.0.0 to 7.0.0.

Release notes

Sourced from acts-as-taggable-on's releases.

v5.0.0

Breaking Changes

@​seuros Drop support for old version of ActiveRecord and Ruby and prepare rel

Added

@​rbritom Tagged with rewrite @​fearenales Due to database collisions, retry finding or creating a tag @​brilyuhns Add owner_tags method to taggable @​brilyuhns upport array of contexts in owner_tags_on method @​brilyuhns Add specs for owner_tags_on and owner_tags methods

Fixes

@​rbritom bump ruby versions for travis @​mnrk Fixed Rails 5.1 deprecation message, has_many needs String value for @​ProGM ProGM Adding a test to demonstrate the bug @​ProGM ProGM Ensure that caching_tag_list_on? is injected before using it @​ProGM ProGM Fix insert query for postgresql. Move schema definition in schema.rb @​amatsuda assigned but unused variable - any @​gmcnaughton Fix incorrect call of 'self.class' on methods which are already class @​gmcnaughton Fixed #712 (incompatibility with ActiveRecord::Sanitization#quoted_id) @​arpitchauhan Guard against indexes already existing @​arpitchauhan Rename migration to avoid conflicts @​lukeasrodgers "Bugfix TagList#concat with non-duplicates." @​fabn Revert "Added missed indexes."

Documentation

Corey Osman Adds a table of contents to the readme and contributing files @​ashishg-qburst Fix typo in README @​praveenangyan Update README.md @​colemerrick update finding tagged objects in readme jaredbeck Help people upgrade to 4.0.0 @​vasinov Update README.md

Changelog

Sourced from acts-as-taggable-on's changelog.

v7.0.0) / 2020-12-31

6.5.0 / 2019-11-07

6.0.0 / 2018-06-19

5.0.0 / 2017-05-18

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Mar 12, 2021
@luisramos0
Copy link
Contributor

I think this may help with a few broekn specs in rails 5.2:


1) Api::OrderCyclesController#products when tag rules apply does not return variants hidden by general rules
     Failure/Error: vo1.update_attribute(:tag_list, default_hide_rule.preferred_variant_tags)
     
     NoMethodError:
       undefined method `[]=' for nil:NilClass
     # /mnt/EXTRA/.rvm/gems/ruby-2.4.4@openfoodnetwork/gems/acts-as-taggable-on-5.0.0/lib/acts_as_taggable_on/taggable/core.rb:206:in `process_dirty_object'
     # /mnt/EXTRA/.rvm/gems/ruby-2.4.4@openfoodnetwork/gems/acts-as-taggable-on-5.0.0/lib/acts_as_taggable_on/taggable/core.rb:184:in `set_tag_list_on'
     # /mnt/EXTRA/.rvm/gems/rub

@luisramos0
Copy link
Contributor

there are some broken specs, maybe we try v6.5 instead?

@Matt-Yorkley
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/acts-as-taggable-on-7.0.0 branch from 0b095f2 to 1fcc77d Compare March 14, 2021 18:47
Copy link
Contributor

@andrewpbrett andrewpbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a green Github build (albeit from a few days ago), I think this looks good. Probably should have a general release test before merging though?

@Matt-Yorkley
Copy link
Contributor

Matt-Yorkley commented Mar 16, 2021

I think we can be pretty confident with a green build here. We use tagging in 6+ core classes, and that behavior is covered in tests.

@andrewpbrett andrewpbrett merged commit 06deab9 into master Mar 16, 2021
@andrewpbrett andrewpbrett deleted the dependabot/bundler/acts-as-taggable-on-7.0.0 branch March 16, 2021 19:31
@luisramos0
Copy link
Contributor

ok, we need to merge or rebase rails-5-2 branch to get this in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current alpha breaks Rails 5 ActiveRecord::Sanitization#quoted_id
3 participants