Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 6.1 support #1013

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Add Rails 6.1 support #1013

merged 1 commit into from
Dec 17, 2020

Conversation

kvokka
Copy link
Contributor

@kvokka kvokka commented Dec 10, 2020

By the way switch from using rails6.0.beta1 to released version in CI

@kvokka kvokka marked this pull request as ready for review December 10, 2020 15:56
@cantino
Copy link

cantino commented Dec 11, 2020

Yes please!

@silva96
Copy link

silva96 commented Dec 11, 2020

why there are 3 pr for rails 6.1 support?

@kvokka
Copy link
Contributor Author

kvokka commented Dec 12, 2020

@silva96 at the moment of this branch creation, PR #1012 was not actually using rails 6.1 gemfiles and in fact it was not working, unfortunately, that pushed me to create this PR

idk why #1015 was created, can only say, that it will not work correctly (you will see it in CI, which by the way runs forever). It has a few issues, which are fixed in this PR.

@silva96
Copy link

silva96 commented Dec 13, 2020

@kvokka thanks for the explanation

@mkilling mkilling mentioned this pull request Dec 14, 2020
@silva96
Copy link

silva96 commented Dec 17, 2020

@mbleigh do you mind take a look here?

@mbleigh
Copy link
Owner

mbleigh commented Dec 17, 2020

Sorry, I haven't been the maintainer of this library for 5+ years 😅 I'm actually not even sure who is the primary maintainer these days.

@mkilling
Copy link
Contributor

@seuros do you by any chance know who currently maintains this repo?

@seuros
Copy link
Collaborator

seuros commented Dec 17, 2020

@mkilling , Sorry i missed this PR. I will check it and release a new version.

@seuros seuros merged commit 06bf141 into mbleigh:master Dec 17, 2020
@seuros
Copy link
Collaborator

seuros commented Dec 17, 2020

If there is no regression in master, this will be released by end of week.
I don't see any warning.

@mrbongiolo
Copy link

Thank you @seuros !!

@silva96
Copy link

silva96 commented Dec 25, 2020

Merry christmas!
@seuros any update with the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants