-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 6.1 support #1013
Add Rails 6.1 support #1013
Conversation
d63a5b3
to
d550312
Compare
d550312
to
37bfebc
Compare
Yes please! |
why there are 3 pr for rails 6.1 support? |
@silva96 at the moment of this branch creation, PR #1012 was not actually using rails 6.1 gemfiles and in fact it was not working, unfortunately, that pushed me to create this PR idk why #1015 was created, can only say, that it will not work correctly (you will see it in CI, which by the way runs forever). It has a few issues, which are fixed in this PR. |
@kvokka thanks for the explanation |
@mbleigh do you mind take a look here? |
Sorry, I haven't been the maintainer of this library for 5+ years 😅 I'm actually not even sure who is the primary maintainer these days. |
@seuros do you by any chance know who currently maintains this repo? |
@mkilling , Sorry i missed this PR. I will check it and release a new version. |
If there is no regression in master, this will be released by end of week. |
Thank you @seuros !! |
Merry christmas! |
By the way switch from using rails6.0.beta1 to released version in CI