Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't seem to bind shortcut using Mac OS X "Command" key modifier #417

Closed
nwg opened this issue Jun 11, 2021 · 3 comments
Closed

Can't seem to bind shortcut using Mac OS X "Command" key modifier #417

nwg opened this issue Jun 11, 2021 · 3 comments

Comments

@nwg
Copy link

nwg commented Jun 11, 2021

Steps to reproduce

Enter Sidebery / Settings and navigate to "Keybindings"
Click "---" or click on existing binding for an enabled key. If there is no key enabled, enable one.
Press some key combo that includes Cmd. For example, Cmd-Shift-1

Expected behavior

Cmd-Shift-1 is bound to action

Actual behavior

Red indicator says "Invalid shortcut" and disappears

Environment info

OS: mac
Firefox: 89.0
Addon: 4.9.4

OS:
Firefox version:
Addon version:

{ "settings": { "version": "4.9.4", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": true, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": false, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "m", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "auto", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": false, "actualAllUrls": true, "actualTabHide": false }, "storage": { "size": "403.6 kb", "props": { "containers_v4": "789 b", "disabledKeybindings": "2 b", "favAutoCleanTime": "10 b", "favUrls": "8.7 kb", "favicons": "389.1 kb", "panelIndex": "1 b", "panels_v4": "1.5 kb", "prevTabsData_v4": "275 b", "profileID": "14 b", "settings": "2.7 kb", "tabsData_v4": "275 b" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "VDgPMyzR2Yc8", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-8", "dropTabCtx": "firefox-container-8", "moveTabCtx": "firefox-container-8", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "nWIXSBQ8UDc8", "name": 8, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-2", "dropTabCtx": "firefox-container-2", "moveTabCtx": "firefox-container-2", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" }, { "type": "tabs", "id": "t__aCnsVj0b8", "name": 7, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-3", "dropTabCtx": "firefox-container-3", "moveTabCtx": "firefox-container-3", "moveTabCtxNoChild": true, "urlRulesActive": true, "urlRules": 11 } ], "containers": [ { "id": "firefox-container-2", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-8", "name": 11, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "cssVars": "TypeError: can't convert undefined to object", "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 7 } ], "bookmarks": { "bookmarksCount": 94, "foldersCount": 8, "separatorsCount": 1, "maxDepth": 2 } }
@nwg
Copy link
Author

nwg commented Jun 11, 2021

Oh, and i should add, that key combo seems to work fine in other parts of firefox. For example, i can use it in about:addons to configure keys for the "Firefox Multi-Account Containers" extension.

@gilzimmerman
Copy link

+1

@mbnuqw
Copy link
Owner

mbnuqw commented Sep 20, 2023

Resolved in v5.0.0

@mbnuqw mbnuqw closed this as completed Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants