Skip favicon resize if it is a SVG containing a CSS media query #1987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom favicons can be passed as a panel icon and they can be SVGs containing dynamic CSS media queries in order to match device light mode (light or dark) for instance.
Sidebery by default redraws the favicon as a PNG, this fix skips this operation if it is a SVG containing a media query.
fixes #1937
Note: in addition to the fix I also renamed favicon variables names in order to emphasis the fact that they are base64 images because it was not clear in the code.