Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define STRICT_R_HEADERS, include float.h, adjust three constants #4

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

eddelbuettel
Copy link
Contributor

Dear BGVAR team,

Your CRAN package BGVAR uses Rcpp, and uses in (just one file) two definition of DOUBLE_EPS, and one of DOUBLE_XMIN, that would go away if we enabled STRICT_R_HEADERS -- as we would like to. Please see the discussion at
RcppCore/Rcpp#1158
and the links therein for more context.

By simply including the standard header <float.h> and defining STRICT_R_HEADERS we can switch to DBL_EPSILON and DBL_MIN instead.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by
RcppCore/Rcpp#1158
to confirm? I do of course see that you have a 2.2.0 ready. Worst case you just shipped this and it may go in the next update; best case you can still adjust 2.2.0.

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.

@mboeck11
Copy link
Owner

Hi,

no worries, I am happy to help. Thanks for the patch!

@eddelbuettel
Copy link
Contributor Author

Thank you--that was fast! Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants