-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for Swift3 with Xcode8GM #42
Conversation
fixed travis tests, make NibDesignable methods `open`, modern demo project
@sstadelman have you seen any issues like:
|
@esetnik no, I haven't seen that... is your framework search path set correctly? |
@sstadelman are you using Cocoapods or carthage to manage your NibDesignable dependency? |
Swift 3 Additions
@mbogh can you rerun the travis tests? They failed with a strange error and the tests pass locally. |
Using |
@mbogh can we get this merged? |
If we could get Travis happy again, I am all for this PR :) |
@mbogh the tests are actually passing it's just that travis was flakey when @sstadelman uploaded his build. You can see a recent passed test run using the same commit at https://travis-ci.org/esetnik/NibDesignable/jobs/160884386. Please rerun the tests on travis and they should pass this time. |
@esetnik See my comment above for the test failure: #42 (comment) |
Travis build has been restart lets see what the verdict is :) |
@farzadshbfn do you have any objections? |
@mbogh no, I had objections against other PR's. this one's so clean 👍 |
This updates the syntax for Swift3, with Xcode-beta6 language updates.
The target
Use Legacy Swift Language Version
build setting is set toNO
.Validated in internal development for ~2 weeks.