Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Swift3 with Xcode8GM #42

Merged
merged 6 commits into from
Sep 19, 2016
Merged

support for Swift3 with Xcode8GM #42

merged 6 commits into from
Sep 19, 2016

Conversation

sstadelman
Copy link
Contributor

This updates the syntax for Swift3, with Xcode-beta6 language updates.

The target Use Legacy Swift Language Version build setting is set to NO.

Validated in internal development for ~2 weeks.

Stadelman, Stan and others added 3 commits August 31, 2016 13:18
@esetnik
Copy link
Contributor

esetnik commented Sep 8, 2016

@sstadelman have you seen any issues like:

9/8/16 12:23:28.546 PM Xcode[39414]: [MT] IBSceneUpdate: [scene update, delegate=<IBStoryboardDocument: 0x7fcc65d9ce00>] Error Domain=com.apple.InterfaceBuilder Code=-1 "Failed to load designables from path /Users/xxx/Library/Developer/Xcode/DerivedData/xxx-chwnxjxzdxmxfqdzqibbbsciffle/Build/Intermediates/IBDesignables/Products/Debug-iphonesimulator/NibDesignable/NibDesignable.framework" UserInfo={NSUnderlyingError=0x7fcc68c319a0 {Error Domain=com.apple.InterfaceBuilder Code=-1 "dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework" UserInfo={NSLocalizedDescription=dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework}}, NSLocalizedFailureReason=dlopen(NibDesignable.framework, 1): Symbol not found: __TMps13OptionSetType
  Referenced from: NibDesignable.framework
  Expected in: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Xcode/Overlays/../../../../../../Toolchains/XcodeDefault.xctoolchain/usr/lib/swift/iphonesimulator/libswiftCore.dylib
 in NibDesignable.framework, NSLocalizedDescription=Failed to load designables from path /Users/xxx/Library/Developer/Xcode/DerivedData/xxx-chwnxjxzdxmxfqdzqibbbsciffle/Build/Intermediates/IBDesignables/Products/Debug-iphonesimulator/NibDesignable/NibDesignable.framework}

@sstadelman
Copy link
Contributor Author

@esetnik no, I haven't seen that... is your framework search path set correctly?

@esetnik
Copy link
Contributor

esetnik commented Sep 8, 2016

@sstadelman are you using Cocoapods or carthage to manage your NibDesignable dependency?

@sstadelman sstadelman changed the title support for Swift3 with Xcode-beta6 support for Swift3 with Xcode8GM Sep 9, 2016
@esetnik
Copy link
Contributor

esetnik commented Sep 10, 2016

@mbogh can you rerun the travis tests? They failed with a strange error and the tests pass locally.

@ikesyo
Copy link
Contributor

ikesyo commented Sep 10, 2016

Using xcodebuild build-for-testing test-without-building should stabilize the CI builds on Travis with Xcode 8.

@esetnik
Copy link
Contributor

esetnik commented Sep 17, 2016

@mbogh can we get this merged?

@mbogh
Copy link
Owner

mbogh commented Sep 17, 2016

If we could get Travis happy again, I am all for this PR :)

@esetnik
Copy link
Contributor

esetnik commented Sep 18, 2016

@mbogh the tests are actually passing it's just that travis was flakey when @sstadelman uploaded his build. You can see a recent passed test run using the same commit at https://travis-ci.org/esetnik/NibDesignable/jobs/160884386. Please rerun the tests on travis and they should pass this time.

@ikesyo
Copy link
Contributor

ikesyo commented Sep 18, 2016

@esetnik See my comment above for the test failure: #42 (comment)

@mbogh
Copy link
Owner

mbogh commented Sep 19, 2016

Travis build has been restart lets see what the verdict is :)

@mbogh
Copy link
Owner

mbogh commented Sep 19, 2016

@farzadshbfn do you have any objections?

@farzadshbfn
Copy link
Collaborator

@mbogh no, I had objections against other PR's. this one's so clean 👍

@mbogh mbogh merged commit 1f4bb40 into mbogh:master Sep 19, 2016
This was referenced Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants