Make convertToVersion strict on empty kind #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This give the converter a chance to convert list items to the requested version.
sttts
commented
May 15, 2018
| func newREST(resource schema.GroupResource, kind, listKind schema.GroupVersionKind, strategy customResourceStrategy, optsGetter generic.RESTOptionsGetter, categories []string, tableConvertor rest.TableConvertor) (*REST, *StatusREST) { | ||
| store := &genericregistry.Store{ | ||
| NewFunc: func() runtime.Object { return &unstructured.Unstructured{} }, | ||
| NewFunc: func() runtime.Object { |
There was a problem hiding this comment.
alternatively we could change convertToVersion to know the GVK instead of deriving it from the Unstructured object.
This was referenced May 15, 2018
Closed
mbohlool
force-pushed
the
crd_versioning_nop
branch
21 times, most recently
from
2b7d8db to
c25514a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the normal scheme we know the full set of registered GVKs of a given object in convertToVersion (https://github.com/sttts/kubernetes/blob/c5445d3c56e06ab366b9cca34bd69c5cc386ec47/staging/src/k8s.io/apimachinery/pkg/runtime/scheme.go#L542). In the case of Unstructured, we have no clue. By setting the GVK in the object we get this information.
Native types' NewFuncs() only return the internal object. For the upper reason this is enough to get the API group.