Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve numeric column text wrapping and some minor touchups #9

Conversation

davismcphee
Copy link

Summary

This PR includes a couple of minor improvements to the Unified Data Table multiline header implementation:

  • Improves multiline wrapping for numeric columns so that text wraps from the left instead of right.
  • Removes the need for manual line-height adjustment on field tokens by adding vertical-align: bottom (or top, either works in this case) to the FieldIcon itself.
  • Replaces a couple of magic numbers in the CSS with equivalent EUI theme variables.
resize.mp4

Copy link
Owner

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested against my PR and I love the improvements! Thanks!

@mbondyra mbondyra merged commit eda5c86 into mbondyra:discover/multiline_table Jan 5, 2024
1 of 2 checks passed
@davismcphee davismcphee deleted the discover-multiline-touchups branch January 5, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants