scalar id support

mbretter · May 7, 2021 · 8883fb5 · 8883fb5
1 parent aba6bcf
commit 8883fb5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/Stk/MongoDB/Connector.php b/src/Stk/MongoDB/Connector.php
@@ -261,15 +261,15 @@ public function delete(ImmutableInterface $row): DeleteResult
     /**
      * delete a document by id
      *
-     * @param string $id
+     * @param mixed $id
      *
      * @return DeleteResult
      */
-    public function deleteById(string $id): DeleteResult
+    public function deleteById($id): DeleteResult
     {
         $this->debug(__METHOD__ . ":$id");
 
-        return $this->_collection->deleteOne(['_id' => new ObjectId($id)]);
+        return $this->_collection->deleteOne(['_id' => is_string($id) ? new ObjectId($id) : $id]);
     }
 
     /**

diff --git a/test/unit/Stk/MongoDB/ConntectorTest.php b/test/unit/Stk/MongoDB/ConntectorTest.php
@@ -423,6 +423,17 @@ public function testDeleteById(): void
         $this->connector->deleteById((string) $oid);
     }
 
+    public function testDeleteByIntId(): void
+    {
+        $id = 99;
+
+        $this->collection->expects($this->once())
+            ->method('deleteOne')
+            ->with(['_id' => $id])
+            ->willReturn($this->createMock(DeleteResult::class));
+        $this->connector->deleteById($id);
+    }
+
     public function testDeleteMany(): void
     {
         $criteria = [