Missing babel-runtime dependency

[vjpr]

It is used in the transpiled output, and should be included as a dep.

This breaks pnpm usage - https://pnpm.js.org/.

[mbrevda]

How (in what way), specifically, does this break pnpm?

[vjpr]

If you require something, it needs to be specified in the package.json.

NPM flattens your dep tree, so if babel-runtime is required by something else, it will be accessible in your node_modules - which is why you wouldn't normally notice this issue. But this is not reliable. All deps should be explicitly specified.

pnpm does not flatten your dep tree.

[mbrevda]

Got it. I'll try to get to this. A PR would be helpful!

…

On Wed, Aug 1, 2018, 3:13 PM Vaughan Rouesnel ***@***.***> wrote: If you require something, it needs to be specified in the package.json. NPM flattens your dep tree, so if babel-runtime is required by something else, it will be accessible in your node_modules. But this is not reliable. All deps should be explicitly specified. pnpm does not flatten your dep tree. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#199 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAR4jHgvENovIi5HeXDrr9v3Y80gwotrks5uMZtXgaJpZM4VqE74> .