Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material-ui renamed pagination callbacks #2556

Closed
vmihalachi opened this issue Oct 19, 2020 · 1 comment
Closed

Material-ui renamed pagination callbacks #2556

vmihalachi opened this issue Oct 19, 2020 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@vmihalachi
Copy link

vmihalachi commented Oct 19, 2020 •
edited
Loading

Describe the bug
Hi, thanks for this great library!

I just noticed that material-ui version 5.0.0-alpha.12 broke the pagination mechanism. They renamed "onChangeRowsPerPage" and "onChangePage" callbacks.
mui/material-ui#22900

Do we have a way to use the newest version and still be compatible? Is component overriding the way to go?
https://material-table.com/#/docs/features/component-overriding

Screenshots

image

image
@vmihalachi vmihalachi added the bug Something isn't working label Oct 19, 2020
@bneigher bneigher mentioned this issue Oct 21, 2020
Closed
@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You can reopen it if it required.

@stale stale bot added the wontfix This will not be worked on label Jan 17, 2021
@stale stale bot closed this as completed Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vmihalachi