-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Rename onChangeRowsPerPage, onChangePage #22900
Conversation
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@eladmotola Thanks! |
Hi, this change broke some stuff. The documentation here is not valid now: https://material-ui.com/api/table-pagination/ and when this prop is not provided the pagination throws an error as these events are undefined. Combined with the documentation being incorrect this makes the simple act of upgrading to the latest material-ui version cause an error: with is not a function throwing internally in the material-ui source. |
That is the documentation for the latest stable release i.e. v4. This PR targetted v5 for which the documentation can be found at https://next.material-ui.com/api/table-pagination |
Hey @eladmotola! 👋 Do you think you might be able to add a deprecation warning for this on the You can probably find a suitable example to follow in #20012 Deprecations section – PR # prefixed with "Dep:". Thanks! |
Hey @mbrookes ! |
No worries, and thanks for your contribution so far! 🙏 We'll try to pick this up before v5, but if you get a chance in the meantime, feel free to jump in. (Would hate to have to revert this! 😅) |
Breaking changes
[Table] Rename
onChangeRowsPerPage
toonRowsPerPageChange
andonChangePage
toonPageChange
due to API consistency.Part of #20012