Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

Fix appveyor builds #43

Closed
mbrt opened this issue Dec 14, 2015 · 4 comments
Closed

Fix appveyor builds #43

mbrt opened this issue Dec 14, 2015 · 4 comments
Labels
Milestone

Comments

@mbrt
Copy link
Owner

mbrt commented Dec 14, 2015

Builds are failing for target x86_64-pc-windows-msvc. The build fails because advapi32-sys can't find ws2_32.lib.

See this PR for a temporary fix, and this rust-lang issue for the complete fix.

@mbrt mbrt added the bug label Dec 14, 2015
@mbrt mbrt added this to the 0.2 milestone Dec 14, 2015
mbrt added a commit that referenced this issue Dec 14, 2015
@mbrt mbrt closed this as completed in afc66cf Dec 14, 2015
@vitaly-krugl
Copy link

@mbrt, sorry to disturb you. I am getting the same errors on appveyor using mingw toolchain in an open-source nupic.core build (https://ci.appveyor.com/project/vitaly-krugl/nupic-core/build/job/5rvqsrgoqryoer7n):

C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lws2_32.lib
C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lmswsock.lib
C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lrpcrt4.lib

The commit afc66cf appears to fix the same issue in your Visual Studio build. Do you know what I need to do to fix the similar issue in mingw builds?

Many thanks,
Vitaly

@mbrt
Copy link
Owner Author

mbrt commented Mar 24, 2016

My problem was about an issue Rust had (or has, I don't know if it is
fixed) in detecting the paths necessary to a proper link in particular
configuration AppVeyor workers has. So calling those batch would set the
PATH variable correctly. I don't know if it's the same issue for you. I
suggest you to ask in the IRC channel if someone else had the same issue,
or to copy the configuration from other crates supporting mingw.
Il 24/mar/2016 22:00, "vitaly-krugl" notifications@github.com ha scritto:

@mbrt https://github.com/mbrt, sorry to disturb you. I am getting the
same errors on appveyor using mingw toolchain in an open-source nupic.core
build (
https://ci.appveyor.com/project/vitaly-krugl/nupic-core/build/job/5rvqsrgoqryoer7n
):

C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lws2_32.lib
C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lmswsock.lib
C:/Python27/share/mingwpy/bin/../lib/gcc/i686-w64-mingw32/4.9.2/../../../../i686-w64-mingw32/bin/ld.exe: cannot find -lrpcrt4.lib

The commit afc66cf
afc66cf
appears to fix the same issue in your Visual Studio build. Do you know what
I need to do to fix the similar issue in mingw builds?

Many thanks,
Vitaly


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#43 (comment)

@vitaly-krugl
Copy link

Thanks @mbrt

@mbrt
Copy link
Owner Author

mbrt commented Mar 24, 2016

You're welcome!
Il 24/mar/2016 22:34, "vitaly-krugl" notifications@github.com ha scritto:

Thanks @mbrt https://github.com/mbrt


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#43 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants