Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add shellcheck for shell scripts #52

Merged
merged 1 commit into from
Apr 26, 2024
Merged

ci: add shellcheck for shell scripts #52

merged 1 commit into from
Apr 26, 2024

Conversation

boringcactus
Copy link
Member

Since we don't manage yamllint via asdf, it seems defensible to not manage shellcheck via asdf here, either.

@boringcactus boringcactus requested a review from a team as a code owner April 25, 2024 21:16
@boringcactus boringcactus requested a review from thecristen April 25, 2024 21:16
thecristen
thecristen approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@thecristen thecristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not 🐚

@boringcactus boringcactus merged commit 648ecb8 into main Apr 26, 2024
4 checks passed
@boringcactus boringcactus deleted the mth-shellcheck branch April 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecristen thecristen thecristen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boringcactus @thecristen