Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use IDs for Stoughton routes on Providence/Stoughton line for Fall 2023 diversion #674

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

clem-hertling
Copy link
Contributor

Summary of changes

Asana Ticket: 🚧 Splice together new Stoughton Branch shapes

So what's going on is, gtfs_creator has a new shape that we need to add to a test here. if the api test has the shape, gtfs_creator builds but the api itself won't pass the tests, because it uses the deployed version which doesn't have the new shape. if the api test has the shape, it will pass but then gtfs_creator won't pass its own tests. And we can't deploy gtfs_creator because it won't pass validation while using the master branch of the api.

anyway, we need to bypass the test check and merge this, so gtfs_creator can pass its build, we can deploy, and then the API will also pass the tests

@clem-hertling clem-hertling requested a review from jfabi September 21, 2023 12:48
@clem-hertling clem-hertling force-pushed the ch-fall23-stoughton-branch branch from 8ec17dc to 2239de0 Compare September 21, 2023 12:49
@clem-hertling
Copy link
Contributor Author

to be clear, this needs more than an approval (thanks @Whoops), bc it doesn't (and won't) pass tests (because it's pulling from gtfs_creator prod, which can't be updated until we merge this in because gtfs_creator CI can't pass without it

so it needs someone to bypass the merge protection (which I can't do, since I'm not an admin on the api repo)

@jfabi
Copy link
Member

jfabi commented Sep 21, 2023

@paulswartz can probably help here.

@paulswartz paulswartz merged commit 431c573 into master Sep 21, 2023
6 of 7 checks passed
@paulswartz
Copy link
Member

@jfabi @clem-hertling all set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants