Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix duplicate route patterns returned when filtering by date #692

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

bfauble
Copy link
Contributor

@bfauble bfauble commented Oct 24, 2023

Summary of changes

Asana Ticket: N/A

list of route_pattern_ids included duplicates because of multiple trips being returned with the same id causing multiple duplicates of the same RoutePattern to be returned via the api when filtering by date.

@bfauble bfauble requested review from a team and Whoops October 24, 2023 14:35
@github-actions
Copy link

Coverage of commit 769bab4

Summary coverage rate:
  lines......: 89.3% (4128 of 4624 lines)
  functions..: 70.9% (2231 of 3145 functions)
  branches...: no data found

Files changed coverage rate:
                                                                        |Lines       |Functions  |Branches    
  Filename                                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================================
  apps/api_web/lib/api_web/controllers/route_pattern_controller.ex      |98.2%     55| 100%    23|    -      0

Download coverage report

@bfauble bfauble merged commit 0da5bcb into master Oct 25, 2023
@bfauble bfauble deleted the bf-remove-duplicate-rpids-via-trips branch October 25, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants