Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump erlang/elixir to sonoma friendly versions #694

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Whoops
Copy link
Collaborator

@Whoops Whoops commented Oct 27, 2023

Summary of changes

Updating Erlang to a version that works on Sonoma

@Whoops Whoops requested review from a team and bfauble October 27, 2023 19:33
@Whoops Whoops temporarily deployed to dev-green October 27, 2023 19:33 — with GitHub Actions Inactive
@Whoops Whoops marked this pull request as draft October 27, 2023 19:42
@Whoops
Copy link
Collaborator Author

Whoops commented Oct 27, 2023

Not bumping straight to Erlang 26 and Elixir 1.15 due to issues with old dependencies we should sort out. Erlang 25.3.2.7 seems to resolve the Sonoma issues in the meantime.

@Whoops Whoops marked this pull request as ready for review October 27, 2023 20:12
@github-actions
Copy link

Coverage of commit b6843dd

Summary coverage rate:
  lines......: 89.3% (4128 of 4624 lines)
  functions..: 70.9% (2231 of 3145 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@fsaid90 fsaid90 requested review from nlwstein and removed request for bfauble October 30, 2023 14:12
@nlwstein
Copy link
Contributor

@Whoops The Dockerfile (and perhaps other locations related to CI) does not pull from the ASDF config: https://github.com/mbta/api/blob/master/Dockerfile

Copy link
Contributor

@nlwstein nlwstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Added comment prior to submitting review - mainly just double check that CI builds pull the same version 🙂 otherwise this looks good!)

@Whoops Whoops requested a review from nlwstein November 3, 2023 20:07
@Whoops
Copy link
Collaborator Author

Whoops commented Nov 3, 2023

Good eye! I knew we we using ASDF for CI, but didn't think to check the Dockerfile. I checked for other instances of hardcoded versions and didn't find any, so I think this covers it now.

Copy link

github-actions bot commented Nov 3, 2023

Coverage of commit b6a0b05

Summary coverage rate:
  lines......: 89.1% (4128 of 4631 lines)
  functions..: 70.9% (2231 of 3145 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link
Contributor

@nlwstein nlwstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bklebe bklebe merged commit af1807e into master Nov 6, 2023
6 checks passed
@bklebe bklebe deleted the wh-erlang-sonoma branch November 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants