-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump erlang/elixir to sonoma friendly versions #694
Conversation
1d0dc1d
to
b6843dd
Compare
Not bumping straight to Erlang 26 and Elixir 1.15 due to issues with old dependencies we should sort out. Erlang 25.3.2.7 seems to resolve the Sonoma issues in the meantime. |
Coverage of commit
|
@Whoops The Dockerfile (and perhaps other locations related to CI) does not pull from the ASDF config: https://github.com/mbta/api/blob/master/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Added comment prior to submitting review - mainly just double check that CI builds pull the same version 🙂 otherwise this looks good!)
b6843dd
to
b6a0b05
Compare
Good eye! I knew we we using ASDF for CI, but didn't think to check the Dockerfile. I checked for other instances of hardcoded versions and didn't find any, so I think this covers it now. |
Coverage of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Summary of changes
Updating Erlang to a version that works on Sonoma