Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: first time setup updates: poetry in .tool-versions and dynamodb file in .gitignore #699

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

meagharty
Copy link
Contributor

@meagharty meagharty commented Nov 8, 2023

Summary of changes

Asana Ticket: No ticket

  • Add poetry back to .tool-versions
    If poetry was intentionally removed from .tool-versions, I could instead update the README to remove the line Run asdf plugin-add poetry to add Poetry plugin.

  • Add local dynamodb metadata file to .gitignore

  • NOTE on undocumented step: For the local dynamoDB setup, I needed to install java on my machine. I installed java globally via asdf. I didn't add instructions to the api_accounts/README but I could if anyone felt strongly about it.

@meagharty meagharty requested review from a team and nlwstein November 8, 2023 14:18
Copy link

github-actions bot commented Nov 8, 2023

Coverage of commit f1774e2

Summary coverage rate:
  lines......: 89.2% (4129 of 4631 lines)
  functions..: 70.9% (2231 of 3145 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@nlwstein
Copy link
Contributor

@meagharty This is totally not blocking but I have found it helpful to run the dynamodb in Docker - a simple version being docker run -p 8000:8000 amazon/dynamodb-local but you could preserve the data in a volume if you wanted to as well.

@meagharty
Copy link
Contributor Author

meagharty commented Nov 13, 2023

@meagharty This is totally not blocking but I have found it helpful to run the dynamodb in Docker - a simple version being docker run -p 8000:8000 amazon/dynamodb-local but you could preserve the data in a volume if you wanted to as well.

@nlwstein Thank you!! good to know that would just work with our setup.

Is it worth updating the docs with that suggestion? I'm not sure how cautious we are with updating public-facing developer documents.

Copy link

Coverage of commit a9f8200

Summary coverage rate:
  lines......: 89.1% (4128 of 4631 lines)
  functions..: 70.9% (2231 of 3145 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@nlwstein
Copy link
Contributor

@meagharty This is totally not blocking but I have found it helpful to run the dynamodb in Docker - a simple version being docker run -p 8000:8000 amazon/dynamodb-local but you could preserve the data in a volume if you wanted to as well.

@nlwstein Thank you!! good to know that would just work with our setup.

Is it worth updating the docs with that suggestion? I'm not sure how cautious we are with updating public-facing developer documents.

I don't think it needs to be updated yet, just figured I would mention it bc it made my setup easy 🙂

This looks good to me!

@meagharty meagharty merged commit a5663e8 into master Nov 15, 2023
@meagharty meagharty deleted the meag/readme branch November 15, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants