poc: try out live-select with shapes select #1035
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meagharty
commented
Nov 8, 2024
mix.exs
Outdated
| {:phoenix_live_react, "~> 0.4"}, | ||
| {:phoenix_html, "~> 4.0"}, | ||
| {:phoenix_html_helpers, "~> 1.0"}, | ||
| {:phoenix_live_react, path: "/Users/mharty/git/phoenix_live_react"}, |
There was a problem hiding this comment.
mix.exs
Outdated
| @@ -79,7 +81,7 @@ defmodule Arrow.MixProject do | |||
| {:telemetry_metrics, "~> 1.0"}, | |||
| {:postgrex, ">= 0.0.0"}, | |||
| # If react_phoenix changes, check assets/src/ReactPhoenix.js, too | |||
| {:react_phoenix, "1.3.1"}, | |||
| {:react_phoenix, path: "/Users/mharty/git/react-phoenix"}, | |||
There was a problem hiding this comment.
| {:lcov_ex, "~> 0.2", only: [:dev, :test], runtime: false}, | ||
| {:mox, "~> 1.2", only: :test}, | ||
| {:oban, "~> 2.18"}, | ||
| {:phoenix_ecto, "~> 4.0"}, | ||
| {:phoenix_live_reload, "~> 1.5", only: :dev}, | ||
| {:phoenix_html, "~> 3.0"}, | ||
| {:phoenix_live_react, "~> 0.4"}, | ||
| {:phoenix_html, "~> 4.0"}, |
There was a problem hiding this comment.
phoenix_live_react and react-phoenix don't have compatibility yet with this version of phoenix_html. See comments with branches of my forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Asana Ticket: No ticket
For illustration, includes some debugging lines etc
Reviewer Checklist