feat(Shuttles): add retrieval of estimates for time to next stop #1043
Conversation
meagharty
changed the title
meagharty
requested review from
a team and
bfauble
and removed request for
a team and
bfauble
meagharty
force-pushed
the
meag/shuttle-add-time-to-next-stop
branch
from
78bf2c6 to
802dde8
Compare
fsaid90
requested review from
a team and
bfauble
and removed request for
bfauble and
a team
meagharty
requested review from
a team and
jzimbel-mbta
and removed request for
a team
| @@ -67,9 +69,37 @@ defmodule Arrow.ShuttlesFixtures do | |||
| def unique_shuttle_route_destination, | |||
| do: "some shuttle_route_destination#{System.unique_integer([:positive])}" | |||
|
|
|||
| defp shuttle_routes do | |||
| defp shuttle_route_stops do | |||
| [stop1, stop2, stop3, stop4] = insert_list(4, :gtfs_stop) | |||
There was a problem hiding this comment.
Noting this because it's not obvious from this PR: phoenix generators with Ecto produce this file with fixtures by default -- I like these as they call the Ecto.Changeset functions (through create_*, in this case on line 139). I believe that's the main difference between these and the manually created ExMachina test data in Arrow.Factory.
We are using ExMachina with options for Ecto where it'll do inserts for you through functions like insert_list. We have one set up for Arrow.Shuttles.Stop and one for Arrow.Gtfs.Stop in Arrow.Factory
meagharty
force-pushed
the
meag/shuttle-add-time-to-next-stop
branch
from
be18956 to
bf1622b
Compare
meagharty
force-pushed
the
meag/shuttle-add-time-to-next-stop
branch
4 times, most recently
from
059f67d to
cba8239
Compare
| @@ -13,6 +13,9 @@ | |||
| - PostgreSQL 15 | |||
| - Can be run as a container via docker-compose by running `docker-compose up -d` in this repository (see `docker-compose.yml`) | |||
| - Using Homebrew: `brew install postgresql@15` | |||
| - OpenRouteService | |||
| - Can use https://api.openrouteservice.org/ with an API key requested through their console | |||
There was a problem hiding this comment.
I hit some issues locally running ORS in docker-compose (it works but after a while it has issues). I expect I need to fine-tune my colima setup for docker-compose.
meagharty
force-pushed
the
meag/shuttle-add-time-to-next-stop
branch
from
03d5379 to
9d96258
Compare
Summary of changes
Asana Ticket: Implement "Create/Edit Shuttle Route Definition" - Time to Next Stop
Reviewer Checklist