-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cancel trips with a boarding status of Canceled #364
base: master
Are you sure you want to change the base?
Conversation
685eda9
to
fb1c3e4
Compare
My assumption going into this was that the StopTimeUpdates with the boarding status were going to be the only STUs for that trip, so we could do an |
@Whoops let me know what you think of the updated approach! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lost track of this! Looks good!
Summary of changes
Asana Ticket: [Investigate] Unexpected predictions during Commuter Rail cancellation
I still need to do a test in dev with actual data, but this should be code-complete and ready to review.
I disabled the Credo cyclomatic complexity warning because I feel that the
filter/3
function is actually quite simple and readable despite the high complexity value, and since I don't see any obvious way to refactor it to be less "complex" per this metric that doesn't make it harder to follow.