Fix Jest watch mode not working #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phildarnowsky
approved these changes
Nov 12, 2019
This was a bug that was fixed in a newer version of Jest, so it only required updating. This also adds a `npm run test:jest:watch` shortcut. The Jest branch coverage threshold had to be adjusted down as part of this, since Jest 24.1.0 fixed an issue where test setup files were included in the code coverage stats. This commit does not change our "real" code coverage.
digitalcora
force-pushed
the
cfg-jest-watch
branch
from
6cb4c9a to
065329d
Compare
|
This is the Jest change I mentioned in standup that removed test setup files from the coverage stats: jestjs/jest#7790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was on my way to write up a tech-debt Asana ticket for this issue, but wondered if it could be as simple as something being outdated. Turns out, it was! (the specific crash was this one) This only took a few minutes to address.
For ease of access, this also adds a
npm run test:jest:watchscript. The default mode only runs tests related to files that have changed.