Android performance/state management refactor #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackVCurtis
force-pushed
the
jvc-android-performance-rnd-2
branch
from
6ed300c
to
1eb0111
Compare
KaylaBrady
approved these changes
Dec 3, 2024
|
|
||
| coordinate = coordinate2 | ||
| composeTestRule.awaitIdle() | ||
| assertEquals(NearbyStaticData(globalResponse, NearbyResponse(builder2)), actualNearby) |
There was a problem hiding this comment.
question: since builder1 and builder2 both don't have any associated objects, are the assertions on 65 and 69 equivalent?
Comment on lines
+47
to
+50
| override fun onCleared() { | ||
| super.onCleared() | ||
| predictionsRepository.disconnect() | ||
| } |
There was a problem hiding this comment.
Nice, looks like this takes care of at least part of leave realtime channels when backgrounding! Do we need to do anything else to rejoin the channels when returning like onCreate? Can be addressed as a follow-up if so!
Comment on lines
-65
to
+61
| check(isConnected) { "called disconnect when not connected" } | ||
| isConnected = false | ||
| launch { disconnectChannel.send(Unit) } | ||
| /* null-op */ |
There was a problem hiding this comment.
question: Is there still a meaningful alternative way to test that disconnect is called as expected? Could we invoke onCleared directly in a test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Address jankiness / lag in UI
What is this PR for?
This PR addresses consistent "jank" (lag, stuttering) in the app due to an overloaded UI thread.
Testing
What testing have you done?
Manual testing for the expected improvements in performance, unit testing for the code changes related to state management.