Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(downstreamAlerts): Ignore alerts without stops specified #559

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

KaylaBrady
Copy link
Collaborator

Summary

Ticket: Display downstream disruptions

What is this PR for?

Follow up to #539 for fixes observed during GL service change yesterday.

  • Alerts without stops specified should not be considered for downstream alerts
  • Missing Service change text description
  • If you added any user facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

Testing

What testing have you done?

  • Added unit test
  • Created test alerts & confirmed expected behavior
    • Blue Line - service change without stops specified
    • Orange Line - service change with stops specified

IMG_0204
IMG_0205

@KaylaBrady KaylaBrady requested a review from a team as a code owner November 27, 2024 16:47
Copy link
Contributor

@JackVCurtis JackVCurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KaylaBrady KaylaBrady merged commit c7b0c99 into main Dec 2, 2024
7 checks passed
@KaylaBrady KaylaBrady deleted the kb-downstream-service branch December 2, 2024 14:52
KaylaBrady added a commit that referenced this pull request Dec 3, 2024
* fix(downstreamAlerts): Ignore alerts without stops specified

* feat(downstreamAlerts): Translations for 'Service change'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants