Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement combined stop + trip departure UI #564

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

EmmaSimon
Copy link
Contributor

Summary

Ticket: Combined stop + trip details: departure list UI

Add horizontally scrolling departure tiles to the new combined stop and trip details page.
Also updates the header to match the spec and include the route pin button.

Simulator Screenshot - iPhone 15 - 2024-12-02 at 22 21 11 Simulator Screenshot - iPhone 15 - 2024-12-02 at 22 21 32

  • If you added any user facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

Testing

Added tests for new components, manual testing of core functionality.

@EmmaSimon EmmaSimon requested a review from a team as a code owner December 3, 2024 03:23
@EmmaSimon EmmaSimon requested a review from BrandonTR December 3, 2024 03:23
@EmmaSimon EmmaSimon force-pushed the es-combined-stop-departures branch from df159b9 to 271707e Compare December 3, 2024 15:28
Copy link
Contributor

@BrandonTR BrandonTR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work! Love the organization and comments.

@EmmaSimon EmmaSimon merged commit f6c9549 into main Dec 4, 2024
7 checks passed
@EmmaSimon EmmaSimon deleted the es-combined-stop-departures branch December 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants