Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Android): sentry integration #569

Merged
merged 11 commits into from
Dec 9, 2024
Merged

feat(Android): sentry integration #569

merged 11 commits into from
Dec 9, 2024

Conversation

KaylaBrady
Copy link
Collaborator

Summary

Ticket: 🤖 | Setup | Sentry integration

What is this PR for?

This PR adds the Sentry integration for the android client.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"
      android
  • All user-facing strings added to strings resource~

Testing

What testing have you done?

I ran locally (disabling the debug check) and confirmed the error was logged in the new project.
image

I don't know how to test the debug symbol upload locally, so I'm hoping to merge this PR as-is with the known temporary message capture on app launch and verify that it works as expected.

@KaylaBrady KaylaBrady requested a review from a team as a code owner December 5, 2024 16:22
create("staging") {
dimension = "environment"
applicationIdSuffix = ".staging"
buildFeatures {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to delete the closing curly brace on the defaultConfig block and move a ton of things inside it and most of the file into the android block?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 it was not!

README.md Outdated Show resolved Hide resolved
@KaylaBrady
Copy link
Collaborator Author

Update:
Removing the temporary log. Debug files were uploaded as part of our CI build. We probably don't need to be doing that, but it doesn't seem to increase run times in a meaningful way, so seems simplest to leave as-is.
image

@KaylaBrady KaylaBrady merged commit 4f46c4a into main Dec 9, 2024
7 checks passed
@KaylaBrady KaylaBrady deleted the kb-android-sentry branch December 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants