feat: Initial new stop page trip details UI #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop rows are still incomplete
KaylaBrady
reviewed
Dec 9, 2024
iosApp/iosApp/Pages/StopDetails/StopDetailsFilteredDepartureDetails.swift
Show resolved
Hide resolved
shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/repositories/TripRepository.kt
Outdated
Show resolved
Hide resolved
Includes some significant refactors to stopDetailsVM trip related logic.
EmmaSimon
force-pushed
the
es-combined-stop-trip-ui
branch
from
8bce648 to
27d485c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
KaylaBrady
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Combined stop + trip details: Trip details UI
Add trip details UI to the combined stop + trip details page, including updated styling for the vehicle card and stop rows, with a colored stop line, target stop pin, and vehicle puck. Also includes some refactors to move trip details logic into the new StopDetailsVM.
iOS
- [ ] If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?- [ ] Add temporary machine translations, marked "Needs Review"android
- [ ] All user-facing strings added to strings resourceTesting
Added tests for new views