Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Android): don't request location automatically #577

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix(Android): don't request location automatically #577

merged 2 commits into from
Dec 11, 2024

Conversation

boringcactus
Copy link
Member

Summary

Ticket: 🤖 | Map | Handle location permissions "only this time"

Aligns with Android best practices around location sharing.

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"

android

  • All user-facing strings added to strings resource

Testing

Manually verified that this behaves as expected.

@boringcactus boringcactus requested a review from a team as a code owner December 10, 2024 17:28
@boringcactus boringcactus merged commit 97218ed into main Dec 11, 2024
5 checks passed
@boringcactus boringcactus deleted the mth-android-manual-location branch December 11, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonTR BrandonTR BrandonTR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boringcactus @BrandonTR