Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Special behavior for target stop on combined stop/trip details #581

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

EmmaSimon
Copy link
Contributor

Summary

Ticket: Combined Stop + Trip Details: Target stop is next or current

This includes a few related updates to how stops appear in the upcoming stop list in combined stop + trip details.

  • When a vehicle is "Now at" a stop, it is removed from the "x stops away" list, if it's approaching or next, it still shows up in the list
  • When the vehicle arrives at the target stop, the vehicle puck in the vehicle card is given the target stop pin icon
  • When the vehicle is stopped at a terminal stop, the text is changed to "Waiting to depart", and the predicted departure time is shown in the vehicle card

Simulator Screenshot - iPhone 15 - 2024-12-11 at 14 45 01 Simulator Screenshot - iPhone 15 - 2024-12-11 at 14 44 39 Simulator Screenshot - iPhone 15 - 2024-12-11 at 14 42 19

iOS

  • If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
    • Add temporary machine translations, marked "Needs Review"
      android
      - [ ] All user-facing strings added to strings resource

Testing

Added tests for the updated behavior

@EmmaSimon EmmaSimon requested a review from a team as a code owner December 11, 2024 19:51
@EmmaSimon EmmaSimon merged commit 39e59d0 into main Dec 12, 2024
7 checks passed
@EmmaSimon EmmaSimon deleted the es-combined-stop-next-target branch December 12, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants